RFR(M): 8059592: Recent bugfixes in ppc64 port.

Discussion:

Lindenmaier, Goetz

2014-10-02 08:06:47 UTC

Hi,

This change contains some bugfixes in the ppc64 coding, and some minor
improvements. It only touches code used in the port.
http://cr.openjdk.java.net/~goetz/webrevs/8059592-ppc_bugs/webrev.00/
https://bugs.openjdk.java.net/browse/JDK-8059592

Please review and test this change. I please need a sponsor.
This change also should go to 8u40, please.

Best regards,
Goetz.

Vladimir Kozlov

2014-10-02 19:20:21 UTC

Permalink

Looks fine. One question is how you can have failing state during code
generation?:

if (Compile::current()->env()->failing()) { return; } // Code cache may
be full.

There should be bailout in opto/output.cpp when codecache is full.
Did it happen because estimated buffer size was less then needed?

Thanks,
Vladimir

Post by Lindenmaier, Goetz
Hi,
This change contains some bugfixes in the ppc64 coding, and some minor
improvements. It only touches code used in the port.
http://cr.openjdk.java.net/~goetz/webrevs/8059592-ppc_bugs/webrev.00/
https://bugs.openjdk.java.net/browse/JDK-8059592
Please review and test this change. I please need a sponsor.
This change also should go to 8u40, please.
Best regards,
Goetz.

Lindenmaier, Goetz

2014-10-04 18:01:49 UTC

Permalink

Hi Vladimir,

I don't know exactly what happened, Martin fixed that.
We have test where we set very small code cache size to
stress the code cache infrastructure, and that test failed.
Martin, can you give more detail?

Best regards,
Goetz

-----Original Message-----
From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Vladimir Kozlov
Sent: Thursday, October 02, 2014 9:20 PM
To: hotspot-dev at openjdk.java.net
Subject: Re: RFR(M): 8059592: Recent bugfixes in ppc64 port.

Looks fine. One question is how you can have failing state during code
generation?:

if (Compile::current()->env()->failing()) { return; } // Code cache may
be full.

There should be bailout in opto/output.cpp when codecache is full.
Did it happen because estimated buffer size was less then needed?

Thanks,
Vladimir

Doerr, Martin

2014-10-06 08:43:33 UTC

Permalink

Hi Vladimir,

we have call nodes which emit trampoline stubs. This may fail if the code cache is too full.
In this case, the emit() function records out-of-memory and returns.

Best regards,
Martin

-----Original Message-----
From: Lindenmaier, Goetz
Sent: Samstag, 4. Oktober 2014 20:02
To: 'Vladimir Kozlov'; 'hotspot-dev at openjdk.java.net'
Cc: Doerr, Martin
Subject: RE: RFR(M): 8059592: Recent bugfixes in ppc64 port.

Hi Vladimir,

I don't know exactly what happened, Martin fixed that.
We have test where we set very small code cache size to
stress the code cache infrastructure, and that test failed.
Martin, can you give more detail?

Best regards,
Goetz

-----Original Message-----
From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Vladimir Kozlov
Sent: Thursday, October 02, 2014 9:20 PM
To: hotspot-dev at openjdk.java.net
Subject: Re: RFR(M): 8059592: Recent bugfixes in ppc64 port.

Looks fine. One question is how you can have failing state during code
generation?:

if (Compile::current()->env()->failing()) { return; } // Code cache may
be full.

There should be bailout in opto/output.cpp when codecache is full.
Did it happen because estimated buffer size was less then needed?

Thanks,
Vladimir

Vladimir Kozlov

2014-10-06 17:19:57 UTC

Permalink

Thank you, Martin, for explanation.

Vladimir

Post by Lindenmaier, Goetz
Hi Vladimir,
we have call nodes which emit trampoline stubs. This may fail if the code cache is too full.
In this case, the emit() function records out-of-memory and returns.
Best regards,
Martin
-----Original Message-----
From: Lindenmaier, Goetz
Sent: Samstag, 4. Oktober 2014 20:02
To: 'Vladimir Kozlov'; 'hotspot-dev at openjdk.java.net'
Cc: Doerr, Martin
Subject: RE: RFR(M): 8059592: Recent bugfixes in ppc64 port.
Hi Vladimir,
I don't know exactly what happened, Martin fixed that.
We have test where we set very small code cache size to
stress the code cache infrastructure, and that test failed.
Martin, can you give more detail?
Best regards,
Goetz
-----Original Message-----
From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Vladimir Kozlov
Sent: Thursday, October 02, 2014 9:20 PM
To: hotspot-dev at openjdk.java.net
Subject: Re: RFR(M): 8059592: Recent bugfixes in ppc64 port.
Looks fine. One question is how you can have failing state during code
if (Compile::current()->env()->failing()) { return; } // Code cache may
be full.
There should be bailout in opto/output.cpp when codecache is full.
Did it happen because estimated buffer size was less then needed?
Thanks,
Vladimir

Lindenmaier, Goetz

2014-10-04 19:50:02 UTC

Permalink

Hi Vladimir,

thanks for pushing both of them! Great you fixed the new
operators for 8.

Best regards,
Goetz.

-----Original Message-----
From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Vladimir Kozlov
Sent: Thursday, October 02, 2014 9:20 PM
To: hotspot-dev at openjdk.java.net
Subject: Re: RFR(M): 8059592: Recent bugfixes in ppc64 port.

Looks fine. One question is how you can have failing state during code
generation?:

if (Compile::current()->env()->failing()) { return; } // Code cache may
be full.

There should be bailout in opto/output.cpp when codecache is full.
Did it happen because estimated buffer size was less then needed?

Thanks,
Vladimir