[8u40] RFR(S) 8059299: assert(adr_type != NULL) failed: expecting TypeKlassPtr

[Vladimir Kozlov]

Backport request. Changes was pushed into jdk9 yesterday. Nighties are
fine (we did not catch the problem for a lot of years so I doubt we have
old tests which are affected).
Changes are applied cleanly to 8u sources except I had to remove changes
in test/TEST.groups since we don't have JPRT jtreg testing for 8u.

http://cr.openjdk.java.net/~kvn/8059299/webrev/
https://bugs.openjdk.java.net/browse/JDK-8059299

jdk9 changeset:
http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/4365e650350d

Review thread:
http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2014-October/015757.html

Thanks,
Vladimir

[David Chase]

Is there an error in your test? I see what looks like a repeated check, where you intended to compare to counter0 at line 73:

70 if (counter1 != 0) {
71 throw new RuntimeException("Failed: counter1(" + counter1 + ") != 0");
72 }
73 if (counter2 != counter) {
74 throw new RuntimeException("Failed: counter2(" + counter2 + ") != counter0(" + counter0 + ")");
75 }
76 if (counter2 != counter) {
77 throw new RuntimeException("Failed: counter2(" + counter2 + ") != counter(" + counter + ")");
78 }
79 System.out.println("TEST PASSED");
80 }

Other than that, to the best of my ability to make sense of what is going on, it looks good.

David

Backport request. Changes was pushed into jdk9 yesterday. Nighties are fine (we did not catch the problem for a lot of years so I doubt we have old tests which are affected).
Changes are applied cleanly to 8u sources except I had to remove changes in test/TEST.groups since we don't have JPRT jtreg testing for 8u.
http://cr.openjdk.java.net/~kvn/8059299/webrev/
https://bugs.openjdk.java.net/browse/JDK-8059299
http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/4365e650350d
http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2014-October/015757.html
Thanks,
Vladimir

[Vladimir Kozlov]

Yes, it is typo. Should be counter2 != counter0

I will fix the test for backport and will push additional fix for jdk9.

Thanks,
Vladimir

Post by David Chase
70 if (counter1 != 0) {
71 throw new RuntimeException("Failed: counter1(" + counter1 + ") != 0");
72 }
73 if (counter2 != counter) {
74 throw new RuntimeException("Failed: counter2(" + counter2 + ") != counter0(" + counter0 + ")");
75 }
76 if (counter2 != counter) {
77 throw new RuntimeException("Failed: counter2(" + counter2 + ") != counter(" + counter + ")");
78 }
79 System.out.println("TEST PASSED");
80 }
Other than that, to the best of my ability to make sense of what is going on, it looks good.
David

Backport request. Changes was pushed into jdk9 yesterday. Nighties are fine (we did not catch the problem for a lot of years so I doubt we have old tests which are affected).
Changes are applied cleanly to 8u sources except I had to remove changes in test/TEST.groups since we don't have JPRT jtreg testing for 8u.
http://cr.openjdk.java.net/~kvn/8059299/webrev/
https://bugs.openjdk.java.net/browse/JDK-8059299
http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/4365e650350d
http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2014-October/015757.html
Thanks,
Vladimir